[Resolver] Origin process #72382

oatkiller · 2020-07-19T05:40:46Z

Co-authored-by: Brent Kimmel brent.kimmel@elastic.co
closes https://github.com/elastic/endpoint-app-team/issues/579

Summary

Center the origin node
Nodes appear selected when they are selected. also the aria attributes are working.
Reposition the submenu when the user pans.

Note: this doesn't include the following. We need a follow up PR

origin node starts off selected

Generally works:

Origin is in the center, selecting nodes works, and the submenu is correctly repositioned when the graph moves.

panels still work

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

kqualters-elastic

👍 code looks fine, the way the process looks not so sure

bkimmel · 2020-07-20T19:28:46Z

...ugins/security_solution/public/resolver/models/indexed_process_tree/isometric_taxi_layout.ts

+}
+
+/**
+ * Return a clone of `model` with all positions incremented by `position`.


❔ Assume by position in this comment you mean translation: Vector2 in the args as below?

oatkiller · 2020-07-20T19:47:15Z

x-pack/plugins/security_solution/common/endpoint/index_data.ts

@@ -94,6 +94,6 @@ async function indexAlerts(
      },
      []
    );
-    await client.bulk({ body, refresh: true });
+    await client.bulk({ body, refresh: 'true' });


typescript error

oatkiller · 2020-07-20T19:48:52Z

...ugins/security_solution/public/resolver/models/indexed_process_tree/isometric_taxi_layout.ts

+}
+
+/**
+ * Return a clone of `model` with all positions incremented by `position`.


oatkiller · 2020-07-20T19:49:03Z

...ugins/security_solution/public/resolver/models/indexed_process_tree/isometric_taxi_layout.ts

+}
+
+/**
+ * Return a clone of `model` with all positions incremented by `position`.


Suggested change

* Return a clone of `model` with all positions incremented by `position`.

* Return a clone of `model` with all positions incremented by `translation`.

oatkiller · 2020-07-20T19:50:56Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

+    const taxiLayout = isometricTaxiLayoutModel.isometricTaxiLayoutFactory(indexedProcessTree);
+
+    if (!originID) {
+      // TODO, this should only happen when no data has loaded.


remove TODO

oatkiller · 2020-07-20T19:51:35Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

+      return taxiLayout;
+    }
+
+    // subtract the origin position from the layout, centering the layout around the origin node


TODO elaborate on how this works in comments

oatkiller · 2020-07-20T19:54:08Z

x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx

@@ -212,7 +207,7 @@ const UnstyledProcessEventDot = React.memo(
      isLabelFilled,
      labelButtonFill,
      strokeColor,
-    } = cubeAssetsForNode(isProcessTerminated, isProcessOrigin);
+    } = cubeAssetsForNode(isProcessTerminated, false);


this isn't defined yet. we dont have a way to know if its a trigger? TODO add comment

oatkiller · 2020-07-20T20:13:39Z

x-pack/plugins/security_solution/public/resolver/store/reducer.ts

-    return {
-      ...uiState,
-      activeDescendantId: action.payload.nodeId,
+    const next: ResolverUIState = {


by using const next: ResolverUIState, typescript will complain about excess properties.

oatkiller · 2020-07-20T20:13:56Z

x-pack/plugins/security_solution/public/resolver/view/assets.tsx

-      return nodeAssets[processTypeToCube.processTerminated];
-    } else if (isProcessOrigin) {
+      if (isProcessTrigger) {
+        return nodeAssets.terminatedTriggerCube;


show the special terminated trigger cube.

bkimmel · 2020-07-20T21:03:42Z

x-pack/plugins/security_solution/public/resolver/view/submenu.tsx

+           * EuiPopover has a mutation observer that observers the child tree and repositions itself.
+           * Abuse this to cause it to reposition itself when the project matrix changes.
+           */}
+          <HiddenSpan data-force-mutation-observer={projectionMatrix.join(', ')} />


🔴 still see our little experiment here.

bkimmel · 2020-07-21T02:52:06Z

x-pack/plugins/security_solution/public/resolver/view/submenu.tsx

+  useMemo,
+  useCallback,
+  useRef,
+  useLayoutEffect,


Suggested change

useLayoutEffect,

CI freaked out on this

apmmachine · 2020-07-21T14:10:30Z

💚 Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #72382 updated]
Start Time: 2020-07-21T14:29:04.543+0000
Duration: 4 min 56 sec

also renames 'isProcessOrigin' params in resolver theme to be 'isProcessTrigger'. NB: this does not use the trigger node styling

UI state changes: * rename `activeDescendantId` to `ariaActiveDescendant`. it has the nodeID (aka entity_id) of the aria active descendant * rename `processEntityIdOfSelectedDescendant` to `selectedNode`. it has the nodeID (aka entity_id) of the selected node * aria html attributes were wrong (this also effected styling.)

oatkiller · 2020-07-21T19:48:17Z

@elasticmachine merge upstream

kibanamachine · 2020-07-21T21:36:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6bc94cd

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+1.1KB	7.3MB

History

💔 Build #63368 failed d8e051c
💚 Build #63324 succeeded 90c24af1e68c3ca6c2ad652880d785e9c99c545c
💔 Build #63302 failed 8d8f44345484448362b62406174a9ab2e1dff53a
💔 Build #63122 failed db691d601c090125e57d4d7b1c7fbd31485454b4
💔 Build #63130 failed c7e6a4a71efb00e076316d01565ab04691f75174

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (23 commits) Stabilize closing toast (elastic#72097) stabilize failing test (elastic#72086) Stabilize filter bar test (elastic#72032) Unskip vislib tests (elastic#71452) [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689) fix preAuth/preRouting mocks (elastic#72663) [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788) [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584) [Security Solution] Fixes exception modal not loading content (elastic#72770) [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748) [Detections] Add validation for Threshold value field (elastic#72611) [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730) [Security Solution][Detections] Validate file type of value lists (elastic#72746) [pre-req] New Component Layout proposal (elastic#72385) [ML] do not throw an error when agg is not supported by UI (elastic#72685) [Resolver] Origin process (elastic#72382) [Ingest Manager] Allow to force unenroll from the UI (elastic#72386) skip 6.8 branch when triggering baseline-capture builds (elastic#72706) [CI] In-progress PR comments (elastic#72211) Fix sorting of scripted string fields (elastic#72681) ...

Co-authored-by: Brent Kimmel <brent.kimmel@elastic.co> * Center the origin node * Nodes appear selected when they are selected. also the aria attributes are working. * Reposition the submenu when the user pans.

kibanamachine · 2020-07-23T21:48:45Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Co-authored-by: Brent Kimmel <brent.kimmel@elastic.co> * Center the origin node * Nodes appear selected when they are selected. also the aria attributes are working. * Reposition the submenu when the user pans. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

oatkiller requested review from bkimmel, dontcallmesherryli, james-elastic and kqualters-elastic July 19, 2020 05:40

oatkiller requested review from a team as code owners July 19, 2020 05:40

oatkiller force-pushed the trigger-proces branch from 3ea8ede to d6ef04f Compare July 19, 2020 05:48

oatkiller added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 19, 2020

oatkiller force-pushed the trigger-proces branch from d6ef04f to ca2b27f Compare July 19, 2020 06:10

kqualters-elastic approved these changes Jul 20, 2020

View reviewed changes

james-elastic approved these changes Jul 20, 2020

View reviewed changes

oatkiller force-pushed the trigger-proces branch 2 times, most recently from 12bceab to b0d689b Compare July 20, 2020 19:25

bkimmel reviewed Jul 20, 2020

View reviewed changes

oatkiller commented Jul 20, 2020

View reviewed changes

bkimmel reviewed Jul 20, 2020

View reviewed changes

bkimmel approved these changes Jul 20, 2020

View reviewed changes

james-elastic approved these changes Jul 20, 2020

View reviewed changes

michaelolo24 approved these changes Jul 20, 2020

View reviewed changes

bkimmel reviewed Jul 21, 2020

View reviewed changes

james-elastic approved these changes Jul 21, 2020

View reviewed changes

oatkiller force-pushed the trigger-proces branch from 1b94170 to 8d8f443 Compare July 21, 2020 14:28

oatkiller added 3 commits July 21, 2020 13:23

Center the origin process.

6f0a90b

also renames 'isProcessOrigin' params in resolver theme to be 'isProcessTrigger'. NB: this does not use the trigger node styling

fix type error in generator code. this must not be in a ts project

819176b

oatkiller added 5 commits July 21, 2020 13:25

cleanup comments

9249262

Reposition popovers when the map changes.

c985ac8

reposition popovers in a different way

b770394

fix extra import

b8a0e68

undo ts fix. it doesnt work

d8e051c

oatkiller force-pushed the trigger-proces branch from 90c24af to d8e051c Compare July 21, 2020 17:25

oatkiller mentioned this pull request Jul 21, 2020

[Resolver] Quick perf fix #72728

Closed

7 tasks

Merge branch 'master' into trigger-proces

6bc94cd

oatkiller merged commit b930cef into elastic:master Jul 21, 2020

oatkiller deleted the trigger-proces branch July 21, 2020 21:47

oatkiller mentioned this pull request Jul 22, 2020

[7.x] [Resolver] Origin process (#72382) #72846

Merged

oatkiller mentioned this pull request Jul 22, 2020

[7.9] [Resolver] Origin process (#72382) #72847

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 23, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Resolver] Origin process #72382

[Resolver] Origin process #72382

oatkiller commented Jul 19, 2020 •

edited by bkimmel

Loading

kqualters-elastic left a comment

bkimmel Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

oatkiller Jul 20, 2020

bkimmel Jul 20, 2020

bkimmel Jul 21, 2020

apmmachine commented Jul 21, 2020 •

edited

Loading

Build stats

oatkiller commented Jul 21, 2020

kibanamachine commented Jul 21, 2020

kibanamachine commented Jul 23, 2020

	* Return a clone of `model` with all positions incremented by `position`.
	* Return a clone of `model` with all positions incremented by `translation`.

[Resolver] Origin process #72382

[Resolver] Origin process #72382

Conversation

oatkiller commented Jul 19, 2020 • edited by bkimmel Loading

Summary

Checklist

For maintainers

kqualters-elastic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apmmachine commented Jul 21, 2020 • edited Loading

💚 Build Succeeded

Build stats

oatkiller commented Jul 21, 2020

kibanamachine commented Jul 21, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

kibanamachine commented Jul 23, 2020

oatkiller commented Jul 19, 2020 •

edited by bkimmel

Loading

apmmachine commented Jul 21, 2020 •

edited

Loading